Skip to content

Commit

Permalink
test: refactored http test to use countdown
Browse files Browse the repository at this point in the history
PR-URL: #17241
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
mithunsasidharan authored and gibfahn committed Dec 19, 2017
1 parent f3c1158 commit 3a0cb8f
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions test/parallel/test-http-end-throw-socket-handling.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
'use strict';
const common = require('../common');
const Countdown = require('../common/countdown');

// Make sure that throwing in 'end' handler doesn't lock
// up the socket forever.
Expand All @@ -8,10 +9,10 @@ const common = require('../common');
// the same, we should not be so brittle and easily broken.

const http = require('http');
const countdown = new Countdown(10, () => server.close());

let n = 0;
const server = http.createServer((req, res) => {
if (++n === 10) server.close();
countdown.dec();
res.end('ok');
});

Expand Down

0 comments on commit 3a0cb8f

Please sign in to comment.