Skip to content

Commit 3bb6f07

Browse files
UlmanbBenjamin Gruenbaum
authored andcommitted
events: add off alias to removeListener
Add `off` as an alias for `removeListener` PR-URL: #17156 Refs: #17102 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 482c27e commit 3bb6f07

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

lib/events.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -307,6 +307,8 @@ EventEmitter.prototype.removeListener =
307307
return this;
308308
};
309309

310+
EventEmitter.prototype.off = EventEmitter.prototype.removeListener;
311+
310312
EventEmitter.prototype.removeAllListeners =
311313
function removeAllListeners(type) {
312314
var listeners, events, i;

test/parallel/test-event-emitter-method-names.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,9 @@ const events = require('events');
2727
const E = events.EventEmitter.prototype;
2828
assert.strictEqual(E.constructor.name, 'EventEmitter');
2929
assert.strictEqual(E.on, E.addListener); // Same method.
30+
assert.strictEqual(E.off, E.removeListener); // Same method.
3031
Object.getOwnPropertyNames(E).forEach(function(name) {
31-
if (name === 'constructor' || name === 'on') return;
32+
if (name === 'constructor' || name === 'on' || name === 'off') return;
3233
if (typeof E[name] !== 'function') return;
3334
assert.strictEqual(E[name].name, name);
3435
});

0 commit comments

Comments
 (0)