Skip to content

Commit

Permalink
build: call setlocal in vcbuild.bat
Browse files Browse the repository at this point in the history
Currently the variables set in vcbuild.bat are mostly global and
escape/leak out into the calling process. For example, running
vcbuild.bat test and then echoing the config variable gives:

vcbuild.bat test
...
echo %config%
Release

After this change the same command give:
vcbuild.bat test
...
echo %config%
%config%

PR-URL: #15754
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
danbev authored and MylesBorins committed Oct 11, 2017
1 parent 0004214 commit 3d2481e
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions vcbuild.bat
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
@echo off

setlocal EnableExtensions

cd %~dp0

if /i "%1"=="help" goto help
Expand Down

0 comments on commit 3d2481e

Please sign in to comment.