Skip to content

Commit

Permalink
build: fix build warning of c-ares under GN build
Browse files Browse the repository at this point in the history
PR-URL: #53750
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
  • Loading branch information
zcbenz authored and aduh95 committed Jul 16, 2024
1 parent 22ca334 commit 3d60b38
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions deps/cares/unofficial.gni
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,17 @@ template("cares_gn_build") {
sources += gypi_values.cares_sources_mac
}

if (is_clang || !is_win) {
cflags_c = [
"-Wno-implicit-fallthrough",
"-Wno-unreachable-code",
]
if (is_clang) {
if (is_win) {
cflags_c = [
"-Wno-macro-redefined",
]
} else {
cflags_c = [
"-Wno-implicit-fallthrough",
"-Wno-unreachable-code",
]
}
}
}
}

0 comments on commit 3d60b38

Please sign in to comment.