test: stop faking performance idlharness

PR-URL: #46794 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs · Mar 13, 2023 · 3daf508 · 3daf508
1 parent c7f056c
commit 3daf508
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 33 deletions.
diff --git a/test/common/wpt.js b/test/common/wpt.js
@@ -526,36 +526,6 @@ class WPTRunner {
  this.globalThisInitScripts.push(script);
  }
 
- brandCheckGlobalScopeAttribute(name) {
- // TODO(legendecas): idlharness GlobalScope attribute receiver validation.
- const script = `
- const desc = Object.getOwnPropertyDescriptor(globalThis, '${name}');
- function getter() {
- // Mimic GlobalScope instance brand check.
- if (this !== globalThis) {
- throw new TypeError('Illegal invocation');
- }
- return desc.get();
- }
- Object.defineProperty(getter, 'name', { value: 'get ${name}' });
-
- function setter(value) {
- // Mimic GlobalScope instance brand check.
- if (this !== globalThis) {
- throw new TypeError('Illegal invocation');
- }
- desc.set(value);
- }
- Object.defineProperty(setter, 'name', { value: 'set ${name}' });
-
- Object.defineProperty(globalThis, '${name}', {
- get: getter,
- set: setter,
- });
- `;
- this.globalThisInitScripts.push(script);
- }
-
  // TODO(joyeecheung): work with the upstream to port more tests in .html
  // to .js.
  async runJsTests() {

diff --git a/test/wpt/status/hr-time.json b/test/wpt/status/hr-time.json
@@ -1,4 +1,11 @@
 {
+ "idlharness.any.js": {
+ "fail": {
+ "expected": [
+ "Window interface: attribute performance"
+ ]
+ }
+ },
  "window-worker-timeOrigin.window.js": {
  "skip": "depends on URL.createObjectURL(blob)"
  }

diff --git a/test/wpt/test-hr-time.js b/test/wpt/test-hr-time.js
@@ -6,6 +6,5 @@ const { WPTRunner } = require('../common/wpt');
 const runner = new WPTRunner('hr-time');
 
 runner.pretendGlobalThisAs('Window');
-runner.brandCheckGlobalScopeAttribute('performance');
 
 runner.runJsTests();
diff --git a/test/wpt/test-performance-timeline.js b/test/wpt/test-performance-timeline.js
@@ -5,7 +5,6 @@ const { WPTRunner } = require('../common/wpt');
 const runner = new WPTRunner('performance-timeline');
 
 runner.pretendGlobalThisAs('Window');
-runner.brandCheckGlobalScopeAttribute('performance');
 runner.setInitScript(`
  // Create a dummy resource timing entry to mimic how the browser would
  // record the initial page load.

diff --git a/test/wpt/test-user-timing.js b/test/wpt/test-user-timing.js
@@ -6,6 +6,5 @@ const { WPTRunner } = require('../common/wpt');
 const runner = new WPTRunner('user-timing');
 
 runner.pretendGlobalThisAs('Window');
-runner.brandCheckGlobalScopeAttribute('performance');
 
 runner.runJsTests();