Skip to content

Commit

Permalink
test: modernize js and tighten equality checking
Browse files Browse the repository at this point in the history
Changed var --> const and let.
Changed assert.notEqual --> assert.notStrictEqual
Fixed comment spelling

PR-URL: #8618
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
wzoom authored and Fishrock123 committed Oct 11, 2016
1 parent 34f24e5 commit 3ddf77f
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions test/parallel/test-child-process-cwd.js
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
'use strict';
var common = require('../common');
var assert = require('assert');
const common = require('../common');
const assert = require('assert');

var returns = 0;
let returns = 0;

/*
Spawns 'pwd' with given options, then test
- whether the exit code equals forCode,
- optionally whether the stdout result matches forData
(after removing traling whitespace)
(after removing trailing whitespace)
*/
function testCwd(options, forCode, forData) {
var data = '';
let data = '';

var child = common.spawnPwd(options);
const child = common.spawnPwd(options);

child.stdout.setEncoding('utf8');

Expand Down Expand Up @@ -46,7 +46,7 @@ if (common.isWindows) {
// Assume does-not-exist doesn't exist, expect exitCode=-1 and errno=ENOENT
{
testCwd({cwd: 'does-not-exist'}, -1).on('error', common.mustCall(function(e) {
assert.equal(e.code, 'ENOENT');
assert.strictEqual(e.code, 'ENOENT');
}));
}

Expand All @@ -58,7 +58,7 @@ testCwd({cwd: undefined}, 0);
testCwd({cwd: null}, 0);

// Check whether all tests actually returned
assert.notEqual(0, returns);
assert.notStrictEqual(returns, 0);
process.on('exit', function() {
assert.equal(0, returns);
assert.strictEqual(returns, 0);
});

0 comments on commit 3ddf77f

Please sign in to comment.