Skip to content

Commit

Permalink
benchmark: chunky http client should exit with 0
Browse files Browse the repository at this point in the history
Previously when there is an error in the chunky client of the
http benchmark, the server would not check the exit code and
thus produce invalid results.

PR-URL: #12916
Fixes: #12903
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
joyeecheung committed May 13, 2017
1 parent 98609fc commit 3fa5d80
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion benchmark/http/http_server_for_chunky_client.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
'use strict';

var assert = require('assert');
var path = require('path');
var http = require('http');
var fs = require('fs');
Expand Down Expand Up @@ -37,6 +38,7 @@ server.listen(PIPE);

var child = fork(pep, process.argv.slice(2));
child.on('message', common.sendResult);
child.on('close', function() {
child.on('close', function(code) {
server.close();
assert.strictEqual(code, 0);
});

0 comments on commit 3fa5d80

Please sign in to comment.