Skip to content

Commit

Permalink
test: http2Stream redundant shutdown and single cb
Browse files Browse the repository at this point in the history
PR-URL: #15612
Refs: #14985
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
trivikr authored and MylesBorins committed Oct 11, 2017
1 parent a4a5bee commit 4153938
Showing 1 changed file with 30 additions and 0 deletions.
30 changes: 30 additions & 0 deletions test/parallel/test-http2-server-shutdown-redundant.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');

const server = http2.createServer();

// Test blank return when a stream.session.shutdown is called twice
// Also tests stream.session.shutdown with just a callback function (no options)
server.on('stream', common.mustCall((stream) => {
stream.session.shutdown(common.mustCall(() => {
assert.strictEqual(
stream.session.shutdown(common.mustNotCall()),
undefined
);
}));
stream.session.shutdown(common.mustNotCall());
}));

server.listen(0, common.mustCall(() => {
const client = http2.connect(`http://localhost:${server.address().port}`);

const req = client.request();
req.resume();
req.on('end', common.mustCall(() => server.close()));
}));

0 comments on commit 4153938

Please sign in to comment.