Skip to content

Commit

Permalink
build: update configure for Node.js 12
Browse files Browse the repository at this point in the history
Update supported level of gcc to 6.3.0 and clang to 8.0.0.

Refs: #26714

PR-URL: #26719
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
richardlau committed Mar 22, 2019
1 parent 0b516fa commit 41ba699
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -740,10 +740,8 @@ def check_compiler(o):
ok, is_clang, clang_version, gcc_version = try_check_compiler(CXX, 'c++')
if not ok:
warn('failed to autodetect C++ compiler version (CXX=%s)' % CXX)
elif sys.platform.startswith('aix') and gcc_version < (6, 3, 0):
warn('C++ compiler too old, need g++ 6.3.0 (CXX=%s)' % CXX)
elif clang_version < (3, 4, 2) if is_clang else gcc_version < (4, 9, 4):
warn('C++ compiler too old, need g++ 4.9.4 or clang++ 3.4.2 (CXX=%s)' % CXX)
elif clang_version < (8, 0, 0) if is_clang else gcc_version < (6, 3, 0):
warn('C++ compiler too old, need g++ 6.3.0 or clang++ 8.0.0 (CXX=%s)' % CXX)

ok, is_clang, clang_version, gcc_version = try_check_compiler(CC, 'c')
if not ok:
Expand Down

0 comments on commit 41ba699

Please sign in to comment.