Skip to content

Commit

Permalink
test_runner: assert entry is a valid object
Browse files Browse the repository at this point in the history
PR-URL: #55231
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
  • Loading branch information
geeksilva97 authored and marco-ippolito committed Nov 17, 2024
1 parent 27564b7 commit 4268517
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/internal/test_runner/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ class Test extends AsyncResource {
const map = lazyFindSourceMap(this.loc.file);
const entry = map?.findEntry(this.loc.line - 1, this.loc.column - 1);

if (entry !== undefined) {
if (entry?.originalSource !== undefined) {
this.loc.line = entry.originalLine + 1;
this.loc.column = entry.originalColumn + 1;
this.loc.file = entry.originalSource;
Expand Down
16 changes: 16 additions & 0 deletions test/parallel/test-runner-enable-source-maps-issue.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
'use strict';
require('../common');
const assert = require('node:assert');
const { spawnSync } = require('node:child_process');
const { test } = require('node:test');
const fixtures = require('../common/fixtures');

test('ensures --enable-source-maps does not throw an error', () => {
const fixture = fixtures.path('test-runner', 'coverage', 'stdin.test.js');
const args = ['--enable-source-maps', fixture];

const result = spawnSync(process.execPath, args);

assert.strictEqual(result.stderr.toString(), '');
assert.strictEqual(result.status, 0);
});

0 comments on commit 4268517

Please sign in to comment.