-
Notifications
You must be signed in to change notification settings - Fork 29.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
collaborator_guide: clarify commit message rules
Italicize the full URL being required in metadata. PR-URL: #5661 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James Snell <jasnell@gmail.com>
- Loading branch information
Showing
1 changed file
with
5 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c4d9ae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should have been "doc:" not "collaborator_guide:" fwiw
4c4d9ae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rvagg, thanks... I wasn't sure on that either :) This could also go into the lint rules for commit messages if we make a tool to help with that.