test: fix flaky http2 tests

Author: apapirovski

test/parallel/test-http2-pipe.js

@@ -21,10 +21,6 @@ const server = http2.createServer();
 server.on('stream', common.mustCall((stream) => {
   const dest = stream.pipe(fs.createWriteStream(fn));
 
-  // we might get an ECONNRESET here
-  // or not
-  stream.on('error', () => {});
-
   dest.on('finish', () => {
     assert.strictEqual(fs.readFileSync(loc).length,
                        fs.readFileSync(fn).length);
@@ -38,10 +34,6 @@ server.listen(0, common.mustCall(() => {
 
   const req = client.request({ ':method': 'POST' });
 
-  // we might get an ECONNRESET here
-  // or not
-  req.on('error', () => {});
-
   req.on('response', common.mustCall());
   req.resume();
 

test/parallel/test-http2-server-close-callback.js

@@ -10,17 +10,15 @@ const server = http2.createServer();
 
 server.listen(0, common.mustCall(() => {
   const client = http2.connect(`http://localhost:${server.address().port}`);
-
-  // depending on network events, this might or might not be emitted
-  client.on('error', () => {});
-
-  client.on('connect', common.mustCall(() => {
-    server.close(common.mustCall());
-  }));
+  client.on('error', (err) => {
+    if (err.code !== 'ECONNRESET')
+      throw err;
+  });
 }));
 
 server.on('session', common.mustCall((s) => {
   setImmediate(() => {
+    server.close(common.mustCall());
     s.destroy();
   });
 }));

test/parallel/test-http2-server-stream-session-destroy.js

@@ -44,10 +44,16 @@ server.on('stream', common.mustCall((stream) => {
 
 server.listen(0, common.mustCall(() => {
   const client = h2.connect(`http://localhost:${server.address().port}`);
-  client.on('error', () => {});
+  client.on('error', (err) => {
+    if (err.code !== 'ECONNRESET')
+      throw err;
+  });
   const req = client.request();
   req.resume();
   req.on('end', common.mustCall());
-  req.on('close', common.mustCall(() => server.close()));
-  req.on('error', () => {});
+  req.on('close', common.mustCall(() => server.close(common.mustCall())));
+  req.on('error', (err) => {
+    if (err.code !== 'ECONNRESET')
+      throw err;
+  });
 }));

test/sequential/test-http2-max-session-memory.js

@@ -13,10 +13,10 @@ const largeBuffer = Buffer.alloc(1e6);
 const server = http2.createServer({ maxSessionMemory: 1 });
 
 server.on('stream', common.mustCall((stream) => {
-  stream.on('error', common.expectsError({
-    code: 'ECONNRESET',
-    type: Error
-  }));
+  stream.on('error', (err) => {
+    if (err.code !== 'ECONNRESET')
+      throw err;
+  });
   stream.respond();
   stream.end(largeBuffer);
 }));