Skip to content

Commit

Permalink
test: update to improve terminology
Browse files Browse the repository at this point in the history
Update common section in wpt to incorporate
improved terminology fixed upstream in
web-platform-tests/wpt#27152

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #37011
Reviewed-By: Milad Fa <mfarazma@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
mhdawson authored and targos committed Feb 2, 2021
1 parent ef2b250 commit 55407b8
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 5 deletions.
2 changes: 1 addition & 1 deletion test/fixtures/wpt/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Last update:
- html/webappapis/microtask-queuing: https://github.com/web-platform-tests/wpt/tree/2c5c3c4c27/html/webappapis/microtask-queuing
- html/webappapis/timers: https://github.com/web-platform-tests/wpt/tree/264f12bc7b/html/webappapis/timers
- hr-time: https://github.com/web-platform-tests/wpt/tree/a5d1774ecf/hr-time
- common: https://github.com/web-platform-tests/wpt/tree/4dacb6e2ff/common
- common: https://github.com/web-platform-tests/wpt/tree/841a51412f/common
- dom/abort: https://github.com/web-platform-tests/wpt/tree/7caa3de747/dom/abort
- FileAPI: https://github.com/web-platform-tests/wpt/tree/d9d921b8f9/FileAPI

Expand Down
3 changes: 3 additions & 0 deletions test/fixtures/wpt/common/sab.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ const createBuffer = (() => {
if (type === "ArrayBuffer") {
return new ArrayBuffer(length);
} else if (type === "SharedArrayBuffer") {
if (sabConstructor.name !== "SharedArrayBuffer") {
throw new Error("WebAssembly.Memory does not support shared:true");
}
return new sabConstructor(length);
} else {
throw new Error("type has to be ArrayBuffer or SharedArrayBuffer");
Expand Down
4 changes: 2 additions & 2 deletions test/fixtures/wpt/common/security-features/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -278,9 +278,9 @@ The ```excluded_tests``` section have objects with the same format as [Test Expa

Taking the spec JSON, the generator follows this algorithm:

* Expand all ```excluded_tests``` to create a blacklist of selections
* Expand all ```excluded_tests``` to create a denylist of selections

* For each `specification` entries: Expand the ```test_expansion``` pattern into selections and check each against the blacklist, if not marked as suppresed, generate the test resources for the selection
* For each `specification` entries: Expand the ```test_expansion``` pattern into selections and check each against the denylist, if not marked as suppresed, generate the test resources for the selection

### SourceContext Resolution

Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/wpt/versions.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"path": "hr-time"
},
"common": {
"commit": "4dacb6e2ff8dbabbe328fde2d8c75491598e4c10",
"commit": "841a51412f236ad63655daca843d3b8e83e0777b",
"path": "common"
},
"dom/abort": {
Expand Down
9 changes: 8 additions & 1 deletion test/wpt/status/encoding.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"requires": ["small-icu"]
},
"textdecoder-streaming.any.js": {
"requires": ["small-icu"]
"requires": ["small-icu"],
"fail": "WebAssembly.Memory does not support shared:true"
},
"textdecoder-utf16-surrogates.any.js": {
"requires": ["small-icu"]
Expand Down Expand Up @@ -50,5 +51,11 @@
},
"streams/*.js": {
"fail": "No implementation of TextDecoderStream and TextEncoderStream"
},
"encodeInto.any.js": {
"fail": "WebAssembly.Memory does not support shared:true"
},
"textdecoder-copy.any.js": {
"fail": "WebAssembly.Memory does not support shared:true"
}
}

0 comments on commit 55407b8

Please sign in to comment.