Skip to content

Commit

Permalink
tools: remove unused trailing function arguments
Browse files Browse the repository at this point in the history
Update tools/doc/html.js and tools/eslint-rules/crypto-check.js to
remove unused trailing function arguments in preparation for enabling a
lint rule to enforce that practice.

PR-URL: #16953
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
  • Loading branch information
Trott authored and MylesBorins committed Nov 17, 2017
1 parent c3c9a8d commit 57937e5
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion tools/doc/html.js
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ function altDocs(filename) {
const host = 'https://nodejs.org';
const href = (v) => `${host}/docs/latest-v${v.num}/api/${filename}.html`;

function li(v, i) {
function li(v) {
let html = `<li><a href="${href(v)}">${v.num}`;

if (v.lts)
Expand Down
2 changes: 1 addition & 1 deletion tools/eslint-rules/crypto-check.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ module.exports = function(context) {
}
}

function reportIfMissingCheck(node) {
function reportIfMissingCheck() {
if (hasSkipCall) {
return;
}
Expand Down
2 changes: 1 addition & 1 deletion tools/eslint-rules/inspector-check.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ module.exports = function(context) {
}
}

function reportIfMissing(context, node) {
function reportIfMissing(context) {
if (!hasInspectorCheck) {
missingCheckNodes.forEach((node) => {
context.report(node, msg);
Expand Down

0 comments on commit 57937e5

Please sign in to comment.