Skip to content

Commit

Permalink
test_runner: remove outdated comment
Browse files Browse the repository at this point in the history
Network imports were removed, so remove the comment.

Refs: #53822
PR-URL: #54146
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
  • Loading branch information
cjihrig authored and targos committed Aug 14, 2024
1 parent 425b956 commit 5a1afb2
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions lib/test/mock_loader.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,6 @@ const { createRequire, isBuiltin } = require('module');
// https://github.com/nodejs/node/issues/49472
// or https://github.com/nodejs/node/issues/52219

// TODO(cjihrig): Network imports should be supported. There are two current
// hurdles:
// - The module format returned by the load() hook is not known. This could be
// implemented as an option, or default to 'module' for network imports.
// - The generated mock module imports 'node:test', which is not allowed by
// checkIfDisallowedImport() in the ESM code.

const mocks = new SafeMap();

async function initialize(data) {
Expand Down

0 comments on commit 5a1afb2

Please sign in to comment.