vm: remove unnecessary HandleScopes

The accessors run inside an implicit HandleScope, there is no need to create a new one. PR-URL: #2001 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
nodejs · Jun 17, 2015 · 5d0cee4 · 5d0cee4
1 parent 91dfb5e
commit 5d0cee4
Showing 1 changed file with 0 additions and 6 deletions.
diff --git a/src/node_contextify.cc b/src/node_contextify.cc
@@ -362,7 +362,6 @@ class ContextifyContext {
       Local<String> property,
       const PropertyCallbackInfo<Value>& args) {
     Isolate* isolate = args.GetIsolate();
-    HandleScope scope(isolate);
 
     ContextifyContext* ctx =
         Unwrap<ContextifyContext>(args.Data().As<Object>());
@@ -387,7 +386,6 @@ class ContextifyContext {
       Local<Value> value,
       const PropertyCallbackInfo<Value>& args) {
     Isolate* isolate = args.GetIsolate();
-    HandleScope scope(isolate);
 
     ContextifyContext* ctx =
         Unwrap<ContextifyContext>(args.Data().As<Object>());
@@ -400,7 +398,6 @@ class ContextifyContext {
       Local<String> property,
       const PropertyCallbackInfo<Integer>& args) {
     Isolate* isolate = args.GetIsolate();
-    HandleScope scope(isolate);
 
     ContextifyContext* ctx =
         Unwrap<ContextifyContext>(args.Data().As<Object>());
@@ -422,7 +419,6 @@ class ContextifyContext {
       Local<String> property,
       const PropertyCallbackInfo<Boolean>& args) {
     Isolate* isolate = args.GetIsolate();
-    HandleScope scope(isolate);
 
     ContextifyContext* ctx =
         Unwrap<ContextifyContext>(args.Data().As<Object>());
@@ -435,8 +431,6 @@ class ContextifyContext {
 
   static void GlobalPropertyEnumeratorCallback(
       const PropertyCallbackInfo<Array>& args) {
-    HandleScope scope(args.GetIsolate());
-
     ContextifyContext* ctx =
         Unwrap<ContextifyContext>(args.Data().As<Object>());