Skip to content

Commit

Permalink
doc: clarify "Reviewed-By" iff "LGTM"
Browse files Browse the repository at this point in the history
As per conversation with @Trott, make it clear that Reviewed-By lines
should only be added for collaborators who've actually put a LGTM on the
PR.

PR-URL: #7183
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: JacksonTian - Jackson Tian <shvyo1987@gmail.com>
  • Loading branch information
bengl authored and jasnell committed Aug 5, 2016
1 parent 9a0d26f commit 5d6d3ee
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions doc/onboarding.md
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ Landing a PR
* `Reviewed-By: human <email>`
* Easiest to use `git log` then do a search
* (`/Name` + `enter` (+ `n` as much as you need to) in vim)
* Only include collaborators who have commented "LGTM"
* `PR-URL: <full-pr-url>`
* `git push upstream master`
* close the original PR with "Landed in `<commit hash>`".
Expand Down

0 comments on commit 5d6d3ee

Please sign in to comment.