Skip to content

Commit

Permalink
test: deflake test-vm-contextified-script-leak
Browse files Browse the repository at this point in the history
Similar to the test-vm-source-text-module-leak fix, use a snapshot
to force a thorough GC in order to prevent false positives.

PR-URL: #49710
Backport-PR-URL: #51004
Refs: nodejs/reliability#669
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
joyeecheung authored and richardlau committed Mar 15, 2024
1 parent 0b156c6 commit 5e42651
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/es-module/test-vm-contextified-script-leak.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ async function createContextifyScript() {
async importModuleDynamically() {},
});
}
checkIfCollectable(createContextifyScript, 2048);
checkIfCollectable(createContextifyScript, 2048, 512);

0 comments on commit 5e42651

Please sign in to comment.