-
Notifications
You must be signed in to change notification settings - Fork 29.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
benchmark: fix child-process-read on Windows
Under Windows 'ipc' communication requires the other process to format its messages with 'IPC framing protocol'. Otherwise, an assert is triggered in libuv. This commit changes child-process-read benchmark to use stdout to communicate with parent process. It also adds child-process-read-ipc.js to benchmark IPC communication using child node process. PR-URL: #6971 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com>
- Loading branch information
Showing
2 changed files
with
47 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
'use strict'; | ||
if (process.argv[2] === 'child') | ||
{ | ||
const len = +process.argv[3]; | ||
const msg = `"${'.'.repeat(len)}"`; | ||
while (true) { | ||
process.send(msg); | ||
} | ||
} else { | ||
const common = require('../common.js'); | ||
const bench = common.createBenchmark(main, { | ||
len: [64, 256, 1024, 4096, 32768], | ||
dur: [5] | ||
}); | ||
const spawn = require('child_process').spawn; | ||
function main(conf) { | ||
bench.start(); | ||
|
||
const dur = +conf.dur; | ||
const len = +conf.len; | ||
|
||
const options = { 'stdio': ['ignore', 'ignore', 'ignore', 'ipc'] }; | ||
const child = spawn(process.argv[0], | ||
[process.argv[1], 'child', len], options); | ||
|
||
var bytes = 0; | ||
child.on('message', function(msg) { | ||
bytes += msg.length; | ||
}); | ||
|
||
setTimeout(function() { | ||
child.kill(); | ||
const gbits = (bytes * 8) / (1024 * 1024 * 1024); | ||
bench.end(gbits); | ||
}, dur * 1000); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters