build: don't store eslint locally

PR-URL: #54231
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

.github/dependabot.yml

@@ -9,3 +9,16 @@ updates:
  commit-message:
  prefix: meta
  open-pull-requests-limit: 10
+
+ - package-ecosystem: npm
+ directory: /tools/eslint
+ schedule:
+ interval: monthly
+ commit-message:
+ prefix: tools
+ open-pull-requests-limit: 10
+ groups:
+ eslint:
+ applies-to: version-updates
+ patterns:
+ - '*'

.github/workflows/tools.yml

@@ -22,7 +22,6 @@ on:
  - cjs-module-lexer
  - corepack
  - doc
- - eslint
  - github_reporter
  - googletest
  - gyp-next
@@ -137,14 +136,6 @@ jobs:
  npm install --ignore-scripts $NEW_VERSION
  npm install --ignore-scripts
  fi
- - id: eslint
- subsystem: tools
- label: tools
- run: |
- ./tools/dep_updaters/update-eslint.sh > temp-output
- cat temp-output
- tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
- rm temp-output
  - id: github_reporter
  subsystem: tools
  label: tools

.gitignore

@@ -112,6 +112,7 @@ tools/*/*.i.tmp
 /node_modules
 /tools/doc/node_modules
 /tools/clang-format/node_modules
+/tools/eslint/node_modules
 
 # === Rules for test artifacts ===
 /*.tap

LICENSE

@@ -2233,29 +2233,6 @@ The externally maintained libraries used by Node.js are:
  OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  """
 
-- ESLint, located at tools/eslint/node_modules/eslint, is licensed as follows:
- """
- Copyright OpenJS Foundation and other contributors, <www.openjsf.org>
-
- Permission is hereby granted, free of charge, to any person obtaining a copy
- of this software and associated documentation files (the "Software"), to deal
- in the Software without restriction, including without limitation the rights
- to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
- copies of the Software, and to permit persons to whom the Software is
- furnished to do so, subject to the following conditions:
-
- The above copyright notice and this permission notice shall be included in
- all copies or substantial portions of the Software.
-
- THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
- OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
- THE SOFTWARE.
- """
-
 - gtest, located at deps/googletest, is licensed as follows:
  """
  Copyright 2008, Google Inc.

Makefile

@@ -1388,16 +1388,19 @@ run-lint-js = tools/eslint/node_modules/eslint/bin/eslint.js --cache \
  --max-warnings=0 --report-unused-disable-directives $(LINT_JS_TARGETS)
 run-lint-js-fix = $(run-lint-js) --fix
 
+tools/eslint/node_modules: tools/eslint/package-lock.json
+ -cd tools/eslint && $(call available-node,$(run-npm-ci))
+
 .PHONY: lint-js-fix
-lint-js-fix:
+lint-js-fix: tools/eslint/node_modules
  @$(call available-node,$(run-lint-js-fix))
 
 .PHONY: lint-js
 .PHONY: lint-js-doc
 # Note that on the CI `lint-js-ci` is run instead.
 # Lints the JavaScript code with eslint.
 lint-js-doc: LINT_JS_TARGETS=doc
-lint-js lint-js-doc:
+lint-js lint-js-doc: tools/eslint/node_modules
  @if [ "$(shell $(node_use_openssl))" != "true" ]; then \
  echo "Skipping $@ (no crypto)"; \
  else \
@@ -1414,7 +1417,7 @@ run-lint-js-ci = tools/eslint/node_modules/eslint/bin/eslint.js \
 
 .PHONY: lint-js-ci
 # On the CI the output is emitted in the TAP format.
-lint-js-ci:
+lint-js-ci: tools/eslint/node_modules
  $(info Running JS linter...)
  @$(call available-node,$(run-lint-js-ci))
 
@@ -1568,7 +1571,7 @@ lint-yaml:
 
 .PHONY: lint
 .PHONY: lint-ci
-ifneq ("","$(wildcard tools/eslint/node_modules/eslint/)")
+ifneq ("","$(wildcard tools/eslint/)")
 lint: ## Run JS, C++, MD and doc linters.
  @EXIT_STATUS=0 ; \
  $(MAKE) lint-js || EXIT_STATUS=$$? ; \
@@ -1599,6 +1602,7 @@ endif
 lint-clean:
  $(RM) tools/.*lintstamp
  $(RM) .eslintcache
+ $(RM) -r tools/eslint/node_modules
 
 HAS_DOCKER ?= $(shell command -v docker > /dev/null 2>&1; [ $$? -eq 0 ] && echo 1 || echo 0)