Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 639f6ff

Browse files
TrottMylesBorins
authored andcommittedMay 18, 2017
test: remove flaky designation for test on AIX
#5085 has been completed so presumably test-fs-watch is not flaky on AIX anymore. Remove flaky designation from sequential.status. PR-URL: #12564 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
1 parent afec45c commit 639f6ff

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed
 

‎test/sequential/sequential.status

-5
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,4 @@ prefix sequential
1616

1717
[$system==freebsd]
1818

19-
# fs-watch currently needs special configuration on AIX and we
20-
# want to improve under https://github.com/nodejs/node/issues/5085.
21-
# Tests are disabled so CI can be green and we can spot other
22-
# regressions until this work is complete
2319
[$system==aix]
24-
test-fs-watch : FAIL,PASS

‎test/sequential/test-fs-watch.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ const fs = require('fs');
66

77
const expectFilePath = common.isWindows ||
88
common.isLinux ||
9-
common.isOSX;
9+
common.isOSX ||
10+
common.isAix;
1011

1112
let watchSeenOne = 0;
1213
let watchSeenTwo = 0;
@@ -80,7 +81,7 @@ const filepathThree = path.join(testsubdir, filenameThree);
8081
assert.doesNotThrow(
8182
function() {
8283
const watcher = fs.watch(testsubdir, function(event, filename) {
83-
const renameEv = common.isSunOS ? 'change' : 'rename';
84+
const renameEv = common.isSunOS || common.isAix ? 'change' : 'rename';
8485
assert.strictEqual(renameEv, event);
8586
if (expectFilePath) {
8687
assert.strictEqual(filename, 'newfile.txt');

0 commit comments

Comments
 (0)
Please sign in to comment.