Skip to content

Commit

Permalink
deps: V8: silence irrelevant warnings
Browse files Browse the repository at this point in the history
Backport-PR-URL: #30513
PR-URL: #26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
  • Loading branch information
targos authored and MylesBorins committed Nov 21, 2019
1 parent 6018db2 commit 6566c15
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.1',
'v8_embedder_string': '-node.2',

##### V8 defaults for Node.js #####

Expand Down
4 changes: 1 addition & 3 deletions deps/v8/include/v8.h
Original file line number Diff line number Diff line change
Expand Up @@ -4640,8 +4640,7 @@ class V8_EXPORT WasmModuleObject : public Object {
* An opaque, native heap object for transferring wasm modules. It
* supports move semantics, and does not support copy semantics.
*/
using TransferrableModule V8_DEPRECATED("Use CompiledWasmModule directly") =
CompiledWasmModule;
using TransferrableModule = CompiledWasmModule;

/**
* Get an in-memory, non-persistable, and context-independent (meaning,
Expand Down Expand Up @@ -7055,7 +7054,6 @@ class PromiseRejectMessage {
typedef void (*PromiseRejectCallback)(PromiseRejectMessage message);

// --- Microtasks Callbacks ---
V8_DEPRECATE_SOON("Use *WithData version.")
typedef void (*MicrotasksCompletedCallback)(Isolate*);
typedef void (*MicrotasksCompletedCallbackWithData)(Isolate*, void*);
typedef void (*MicrotaskCallback)(void* data);
Expand Down

0 comments on commit 6566c15

Please sign in to comment.