querystring: simplify stringify method

PR-URL: #26591 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
nodejs · Apr 9, 2019 · 6c40f7f · 6c40f7f
1 parent db7df0f
commit 6c40f7f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/benchmark/querystring/querystring-stringify.js b/benchmark/querystring/querystring-stringify.js
@@ -3,8 +3,8 @@ const common = require('../common.js');
 const querystring = require('querystring');
 
 const bench = common.createBenchmark(main, {
-  type: ['noencode', 'encodemany', 'encodelast'],
-  n: [1e7],
+  type: ['noencode', 'encodemany', 'encodelast', 'array'],
+  n: [1e6],
 });
 
 function main({ type, n }) {
@@ -23,6 +23,11 @@ function main({ type, n }) {
       foo: 'bar',
       baz: 'quux',
       xyzzy: 'thu\u00AC'
+    },
+    array: {
+      foo: [],
+      baz: ['bar'],
+      xyzzy: ['bar', 'quux', 'thud']
     }
   };
   const input = inputs[type];

diff --git a/lib/querystring.js b/lib/querystring.js
@@ -176,19 +176,19 @@ function stringify(obj, sep, eq, options) {
 
       if (Array.isArray(v)) {
         var vlen = v.length;
+        if (vlen === 0) continue;
         var vlast = vlen - 1;
         for (var j = 0; j < vlen; ++j) {
           fields += ks + encode(stringifyPrimitive(v[j]));
           if (j < vlast)
             fields += sep;
         }
-        if (vlen && i < flast)
-          fields += sep;
       } else {
         fields += ks + encode(stringifyPrimitive(v));
-        if (i < flast)
-          fields += sep;
       }
+
+      if (i < flast)
+        fields += sep;
     }
     return fields;
   }