test: give js-native-api tests consistent names

gabrielschulhof · danielleadams · commit 6da4aa30c6f3 · 2021-05-31T15:34:47.000-04:00
The convention for js-native-api/<test_name>: * <test_name>.c or <test_name>.cc has the entry point * The name of the target is <test_name> PR-URL: #38692 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/test/js-native-api/2_function_arguments/2_function_arguments.c b/test/js-native-api/2_function_arguments/2_function_arguments.c
diff --git a/test/js-native-api/2_function_arguments/binding.gyp b/test/js-native-api/2_function_arguments/binding.gyp
@@ -1,10 +1,10 @@
 {
   "targets": [
     {
-      "target_name": "binding",
+      "target_name": "2_function_arguments",
       "sources": [
         "../entry_point.c",
-        "binding.c"
+        "2_function_arguments.c"
       ]
     }
   ]
diff --git a/test/js-native-api/2_function_arguments/test.js b/test/js-native-api/2_function_arguments/test.js
@@ -1,6 +1,6 @@
 'use strict';
 const common = require('../../common');
 const assert = require('assert');
-const addon = require(`./build/${common.buildType}/binding`);
+const addon = require(`./build/${common.buildType}/2_function_arguments`);
 
 assert.strictEqual(addon.add(3, 5), 8);
diff --git a/test/js-native-api/3_callbacks/3_callbacks.c b/test/js-native-api/3_callbacks/3_callbacks.c
diff --git a/test/js-native-api/3_callbacks/binding.gyp b/test/js-native-api/3_callbacks/binding.gyp
@@ -1,10 +1,10 @@
 {
   "targets": [
     {
-      "target_name": "binding",
+      "target_name": "3_callbacks",
       "sources": [
         "../entry_point.c",
-        "binding.c"
+        "3_callbacks.c"
       ]
     }
   ]
diff --git a/test/js-native-api/3_callbacks/test.js b/test/js-native-api/3_callbacks/test.js
@@ -1,7 +1,7 @@
 'use strict';
 const common = require('../../common');
 const assert = require('assert');
-const addon = require(`./build/${common.buildType}/binding`);
+const addon = require(`./build/${common.buildType}/3_callbacks`);
 
 addon.RunCallback(function(msg) {
   assert.strictEqual(msg, 'hello world');
diff --git a/test/js-native-api/4_object_factory/4_object_factory.c b/test/js-native-api/4_object_factory/4_object_factory.c
diff --git a/test/js-native-api/4_object_factory/binding.gyp b/test/js-native-api/4_object_factory/binding.gyp
@@ -1,10 +1,10 @@
 {
   "targets": [
     {
-      "target_name": "binding",
+      "target_name": "4_object_factory",
       "sources": [
         "../entry_point.c",
-        "binding.c"
+        "4_object_factory.c"
       ]
     }
   ]
diff --git a/test/js-native-api/4_object_factory/test.js b/test/js-native-api/4_object_factory/test.js
@@ -1,7 +1,7 @@
 'use strict';
 const common = require('../../common');
 const assert = require('assert');
-const addon = require(`./build/${common.buildType}/binding`);
+const addon = require(`./build/${common.buildType}/4_object_factory`);
 
 const obj1 = addon('hello');
 const obj2 = addon('world');
diff --git a/test/js-native-api/5_function_factory/5_function_factory.c b/test/js-native-api/5_function_factory/5_function_factory.c
diff --git a/test/js-native-api/5_function_factory/binding.gyp b/test/js-native-api/5_function_factory/binding.gyp
@@ -1,10 +1,10 @@
 {
   "targets": [
     {
-      "target_name": "binding",
+      "target_name": "5_function_factory",
       "sources": [
         "../entry_point.c",
-        "binding.c"
+        "5_function_factory.c"
       ]
     }
   ]
diff --git a/test/js-native-api/5_function_factory/test.js b/test/js-native-api/5_function_factory/test.js
@@ -1,7 +1,7 @@
 'use strict';
 const common = require('../../common');
 const assert = require('assert');
-const addon = require(`./build/${common.buildType}/binding`);
+const addon = require(`./build/${common.buildType}/5_function_factory`);
 
 const fn = addon();
 assert.strictEqual(fn(), 'hello world'); // 'hello world'
diff --git a/test/js-native-api/6_object_wrap/6_object_wrap.cc b/test/js-native-api/6_object_wrap/6_object_wrap.cc
diff --git a/test/js-native-api/6_object_wrap/binding.gyp b/test/js-native-api/6_object_wrap/binding.gyp
@@ -1,10 +1,10 @@
 {
   "targets": [
     {
-      "target_name": "binding",
+      "target_name": "6_object_wrap",
       "sources": [
         "../entry_point.c",
-        "myobject.cc"
+        "6_object_wrap.cc"
       ]
     }
   ]
diff --git a/test/js-native-api/6_object_wrap/test.js b/test/js-native-api/6_object_wrap/test.js
@@ -1,7 +1,7 @@
 'use strict';
 const common = require('../../common');
 const assert = require('assert');
-const addon = require(`./build/${common.buildType}/binding`);
+const addon = require(`./build/${common.buildType}/6_object_wrap`);
 
 const getterOnlyErrorRE =
   /^TypeError: Cannot set property .* of #<.*> which has only a getter$/;
diff --git a/test/js-native-api/7_factory_wrap/7_factory_wrap.cc b/test/js-native-api/7_factory_wrap/7_factory_wrap.cc
diff --git a/test/js-native-api/7_factory_wrap/binding.gyp b/test/js-native-api/7_factory_wrap/binding.gyp
@@ -1,10 +1,10 @@
 {
   "targets": [
     {
-      "target_name": "binding",
+      "target_name": "7_factory_wrap",
       "sources": [
         "../entry_point.c",
-        "binding.cc",
+        "7_factory_wrap.cc",
         "myobject.cc"
       ]
     }
diff --git a/test/js-native-api/7_factory_wrap/test.js b/test/js-native-api/7_factory_wrap/test.js
@@ -3,7 +3,7 @@
 
 const common = require('../../common');
 const assert = require('assert');
-const test = require(`./build/${common.buildType}/binding`);
+const test = require(`./build/${common.buildType}/7_factory_wrap`);
 
 assert.strictEqual(test.finalizeCount, 0);
 async function runGCTests() {
diff --git a/test/js-native-api/8_passing_wrapped/8_passing_wrapped.cc b/test/js-native-api/8_passing_wrapped/8_passing_wrapped.cc
diff --git a/test/js-native-api/8_passing_wrapped/binding.gyp b/test/js-native-api/8_passing_wrapped/binding.gyp
@@ -1,10 +1,10 @@
 {
   "targets": [
     {
-      "target_name": "binding",
+      "target_name": "8_passing_wrapped",
       "sources": [
         "../entry_point.c",
-        "binding.cc",
+        "8_passing_wrapped.cc",
         "myobject.cc"
       ]
     }
diff --git a/test/js-native-api/8_passing_wrapped/test.js b/test/js-native-api/8_passing_wrapped/test.js
@@ -3,7 +3,7 @@
 
 const common = require('../../common');
 const assert = require('assert');
-const addon = require(`./build/${common.buildType}/binding`);
+const addon = require(`./build/${common.buildType}/8_passing_wrapped`);
 
 async function runTest() {
   let obj1 = addon.createObject(10);
diff --git a/test/js-native-api/test_new_target/binding.gyp b/test/js-native-api/test_new_target/binding.gyp
@@ -1,11 +1,11 @@
 {
   'targets': [
     {
-      'target_name': 'binding',
+      'target_name': 'test_new_target',
       'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
       'sources': [
         '../entry_point.c',
-        'binding.c'
+        'test_new_target.c'
       ]
     }
   ]
diff --git a/test/js-native-api/test_new_target/test.js b/test/js-native-api/test_new_target/test.js
@@ -2,7 +2,7 @@
 
 const common = require('../../common');
 const assert = require('assert');
-const binding = require(`./build/${common.buildType}/binding`);
+const binding = require(`./build/${common.buildType}/test_new_target`);
 
 class Class extends binding.BaseClass {
   constructor() {
diff --git a/test/js-native-api/test_new_target/test_new_target.c b/test/js-native-api/test_new_target/test_new_target.c

Original file line number	Diff line number	Diff line change
`@@ -1,10 +1,10 @@`
`1`	`1`	`{`
`2`	`2`	`"targets": [`
`3`	`3`	`{`
`4`		`- "target_name": "binding",`
	`4`	`+ "target_name": "2_function_arguments",`
`5`	`5`	`"sources": [`
`6`	`6`	`"../entry_point.c",`
`7`		`- "binding.c"`
	`7`	`+ "2_function_arguments.c"`
`8`	`8`	`]`
`9`	`9`	`}`
`10`	`10`	`]`