Skip to content

Commit

Permalink
readline: make Symbol.asyncIterator support stable
Browse files Browse the repository at this point in the history
PR-URL: #26989
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
  • Loading branch information
mcollina authored and BethGriggs committed Oct 18, 2019
1 parent 00831f0 commit 79f3844
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
8 changes: 6 additions & 2 deletions doc/api/readline.md
Original file line number Diff line number Diff line change
Expand Up @@ -311,10 +311,14 @@ The `rl.write()` method will write the data to the `readline` `Interface`'s

### rl\[Symbol.asyncIterator\]()
<!-- YAML
added: v10.16.0
added: v11.4.0
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/26989
description: Symbol.asyncIterator support is no longer experimental.
-->

> Stability: 1 - Experimental
> Stability: 2 - Stable
* Returns: {AsyncIterator}

Expand Down
4 changes: 1 addition & 3 deletions lib/readline.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ const {
ERR_INVALID_CURSOR_POS,
ERR_INVALID_OPT_VALUE
} = require('internal/errors').codes;

const { debug, inherits } = require('util');
const { emitExperimentalWarning } = require('internal/util');
const { Buffer } = require('buffer');
const EventEmitter = require('events');
const {
Expand Down Expand Up @@ -1005,8 +1005,6 @@ Interface.prototype._ttyWrite = function(s, key) {
};

Interface.prototype[Symbol.asyncIterator] = function() {
emitExperimentalWarning('readline Interface [Symbol.asyncIterator]');

if (this[kLineObjectStream] === undefined) {
if (Readable === undefined) {
Readable = require('stream').Readable;
Expand Down

0 comments on commit 79f3844

Please sign in to comment.