Skip to content

Commit

Permalink
test: mark flaky tests on IBM i
Browse files Browse the repository at this point in the history
PR-URL: #36986
Refs: #34410
Refs: #36925
Refs: #36929
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
richardlau authored and ruyadorno committed Jan 25, 2021
1 parent 743dd8f commit 7acea78
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 0 deletions.
11 changes: 11 additions & 0 deletions test/abort/abort.status
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
prefix abort

# To mark a test as flaky, list the test name in the appropriate section
# below, without ".js", followed by ": PASS,FLAKY". Example:
# sample-test : PASS,FLAKY

[true] # This section applies to all platforms

[$system==ibmi]
# https://github.com/nodejs/node/issues/34410
test-addon-register-signal-handler: PASS,FLAKY
2 changes: 2 additions & 0 deletions test/addons/addon.status
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,5 @@ openssl-binding/test: PASS,FLAKY
[$system==ibmi]
openssl-binding/test: SKIP
zlib-binding/test: SKIP
# https://github.com/nodejs/node/issues/34410
register-signal-handler/test: PASS,FLAKY
4 changes: 4 additions & 0 deletions test/parallel/parallel.status
Original file line number Diff line number Diff line change
Expand Up @@ -69,3 +69,7 @@ test-net-write-after-end-nt: SKIP
test-tls-env-extra-ca: SKIP
# https://github.com/nodejs/node/pull/34209
test-dgram-error-message-address: SKIP
# https://github.com/nodejs/node/issues/36929
test-crypto-secure-heap: PASS,FLAKY
# https://github.com/nodejs/node/issues/36925
test-fs-read-type: PASS,FLAKY

0 comments on commit 7acea78

Please sign in to comment.