Skip to content

Commit

Permalink
src: fix -Winconsistent-missing-override warning
Browse files Browse the repository at this point in the history
../src/node_http_common.h:497:8: warning: 'MemoryInfo' overrides a
member function but is not marked 'override' [-Winconsistent-missing-override]
  void MemoryInfo(MemoryTracker* tracker) const {

PR-URL: #32126
Refs: #32069
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
  • Loading branch information
cjihrig authored and MylesBorins committed Mar 9, 2020
1 parent a79b8fa commit 7b9b578
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/node_http_common.h
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ class NgHeader : public MemoryRetainer {
inline std::string value() const;
inline size_t length() const;

void MemoryInfo(MemoryTracker* tracker) const {
void MemoryInfo(MemoryTracker* tracker) const override {
tracker->TrackField("name", name_);
tracker->TrackField("value", value_);
}
Expand Down

0 comments on commit 7b9b578

Please sign in to comment.