Skip to content

Commit 7f080a3

Browse files
committed
test: reduce flakiness in test-heapdump-http2
By the time the response event is emitted on the client's side, the file may have already been fully piped and the stream pipe may have been destroyed, so the test should not look for the stream pipe in the snapshot.
1 parent 723d7bb commit 7f080a3

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

test/pummel/test-heapdump-http2.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,9 @@ server.listen(0, () => {
4848
{ node_name: 'TCP', edge_name: 'native_to_javascript' },
4949
]);
5050

51-
// `Node / StreamPipe` (C++) -> StreamPipe (JS)
52-
validateByRetainingPathFromNodes(nodes, 'Node / StreamPipe', [
53-
{ node_name: 'StreamPipe', edge_name: 'native_to_javascript' },
54-
]);
51+
// We don't necessarily have Node / StreamPipe here because by the time the
52+
// response event is emitted, the file may have already been fully piped here
53+
// and the stream pipe may have been destroyed.
5554

5655
// `Node / Http2Session` (C++) -> Http2Session (JS)
5756
const sessions = validateByRetainingPathFromNodes(nodes, 'Node / Http2Session', []);

0 commit comments

Comments
 (0)