Skip to content

Commit

Permalink
deps: do not link against librt
Browse files Browse the repository at this point in the history
It is not needed, and causes an unnecessary runtime dependency with some
linkers, such as devtoolset-6 on centos7-ppc64le.

See: #29718

PR-URL: #29729
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
  • Loading branch information
sam-github authored and BethGriggs committed Oct 1, 2019
1 parent 15c2eb0 commit 7f48519
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion deps/uv/uv.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@
'src/unix/sysinfo-memory.c',
],
'link_settings': {
'libraries': [ '-ldl', '-lrt' ],
'libraries': [ '-ldl' ],
},
}],
[ 'OS=="android"', {
Expand Down
3 changes: 1 addition & 2 deletions deps/v8/gypfiles/v8.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -1975,8 +1975,7 @@
# library order and break (see crbug.com/469973).
# These libraries do not exist on Mac hosted builds.
'libraries': [
'-ldl',
'-lrt'
'-ldl'
]
}]
]
Expand Down

0 comments on commit 7f48519

Please sign in to comment.