src: remove MarkIndependent() calls

The method has been deprecated in upstream V8, with messaging indicating that it is the default for handles to be independent now anyway. PR-URL: #20108 Refs: v8/v8@71ad48f Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
nodejs · Apr 23, 2018 · 80c46c1 · 80c46c1
1 parent 881fca4
commit 80c46c1
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 6 deletions.
diff --git a/src/base_object-inl.h b/src/base_object-inl.h
@@ -70,7 +70,6 @@ inline void BaseObject::MakeWeak(Type* ptr) {
   v8::Local<v8::Object> handle = object();
   CHECK_GT(handle->InternalFieldCount(), 0);
   Wrap(handle, ptr);
-  persistent_handle_.MarkIndependent();
   persistent_handle_.SetWeak<Type>(ptr, WeakCallback<Type>,
                                    v8::WeakCallbackType::kParameter);
 }

diff --git a/src/node_api.cc b/src/node_api.cc
@@ -387,7 +387,6 @@ class Reference : private Finalizer {
     if (initial_refcount == 0) {
       _persistent.SetWeak(
           this, FinalizeCallback, v8::WeakCallbackType::kParameter);
-      _persistent.MarkIndependent();
     }
   }
 
@@ -431,7 +430,6 @@ class Reference : private Finalizer {
     if (--_refcount == 0) {
       _persistent.SetWeak(
           this, FinalizeCallback, v8::WeakCallbackType::kParameter);
-      _persistent.MarkIndependent();
     }
 
     return _refcount;

diff --git a/src/node_buffer.cc b/src/node_buffer.cc
@@ -144,7 +144,6 @@ CallbackInfo::CallbackInfo(Isolate* isolate,
 
   persistent_.SetWeak(this, WeakCallback, v8::WeakCallbackType::kParameter);
   persistent_.SetWrapperClassId(BUFFER_ID);
-  persistent_.MarkIndependent();
   isolate->AdjustAmountOfExternalAllocatedMemory(sizeof(*this));
 }
 

diff --git a/src/node_contextify.cc b/src/node_contextify.cc
@@ -104,7 +104,6 @@ ContextifyContext::ContextifyContext(
   if (context_.IsEmpty())
     return;
   context_.SetWeak(this, WeakCallback, v8::WeakCallbackType::kParameter);
-  context_.MarkIndependent();
 }
 
 

diff --git a/src/node_object_wrap.h b/src/node_object_wrap.h
@@ -83,7 +83,6 @@ class ObjectWrap {
 
   inline void MakeWeak(void) {
     persistent().SetWeak(this, WeakCallback, v8::WeakCallbackType::kParameter);
-    persistent().MarkIndependent();
   }
 
   /* Ref() marks the object as being attached to an event loop.
-Original file line number
+Diff line change
@@ Expand Up / @@ -104,7 +104,6 @@ ContextifyContext::ContextifyContext( @@
       if (context_.IsEmpty())
         return;
       context_.SetWeak(this, WeakCallback, v8::WeakCallbackType::kParameter);
-      context_.MarkIndependent();
     }
@@ Expand Down @@