Skip to content

Commit 80c46c1

Browse files
addaleaxjasnell
authored andcommitted
src: remove MarkIndependent() calls
The method has been deprecated in upstream V8, with messaging indicating that it is the default for handles to be independent now anyway. PR-URL: #20108 Refs: v8/v8@71ad48f Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
1 parent 881fca4 commit 80c46c1

File tree

5 files changed

+0
-6
lines changed

5 files changed

+0
-6
lines changed

src/base_object-inl.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ inline void BaseObject::MakeWeak(Type* ptr) {
7070
v8::Local<v8::Object> handle = object();
7171
CHECK_GT(handle->InternalFieldCount(), 0);
7272
Wrap(handle, ptr);
73-
persistent_handle_.MarkIndependent();
7473
persistent_handle_.SetWeak<Type>(ptr, WeakCallback<Type>,
7574
v8::WeakCallbackType::kParameter);
7675
}

src/node_api.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,6 @@ class Reference : private Finalizer {
387387
if (initial_refcount == 0) {
388388
_persistent.SetWeak(
389389
this, FinalizeCallback, v8::WeakCallbackType::kParameter);
390-
_persistent.MarkIndependent();
391390
}
392391
}
393392

@@ -431,7 +430,6 @@ class Reference : private Finalizer {
431430
if (--_refcount == 0) {
432431
_persistent.SetWeak(
433432
this, FinalizeCallback, v8::WeakCallbackType::kParameter);
434-
_persistent.MarkIndependent();
435433
}
436434

437435
return _refcount;

src/node_buffer.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,6 @@ CallbackInfo::CallbackInfo(Isolate* isolate,
144144

145145
persistent_.SetWeak(this, WeakCallback, v8::WeakCallbackType::kParameter);
146146
persistent_.SetWrapperClassId(BUFFER_ID);
147-
persistent_.MarkIndependent();
148147
isolate->AdjustAmountOfExternalAllocatedMemory(sizeof(*this));
149148
}
150149

src/node_contextify.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ ContextifyContext::ContextifyContext(
104104
if (context_.IsEmpty())
105105
return;
106106
context_.SetWeak(this, WeakCallback, v8::WeakCallbackType::kParameter);
107-
context_.MarkIndependent();
108107
}
109108

110109

src/node_object_wrap.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ class ObjectWrap {
8383

8484
inline void MakeWeak(void) {
8585
persistent().SetWeak(this, WeakCallback, v8::WeakCallbackType::kParameter);
86-
persistent().MarkIndependent();
8786
}
8887

8988
/* Ref() marks the object as being attached to an event loop.

0 commit comments

Comments
 (0)