-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Use common.mustNotCall() and common.mustCall() as appropriate * Use block scoping * Move assertions out of `exit` handler and into callbacks * Order assert.strictEqual() args per docs * Remove console.log() calls * Move test from `parallel` to `sequential` so `common.PORT` can be used without conflicting with OS-provided ports in other `parallel` tests PR-URL: #13273 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
- Loading branch information
Showing
2 changed files
with
64 additions
and
86 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const net = require('net'); | ||
|
||
|
||
// With only a callback, server should get a port assigned by the OS | ||
{ | ||
const server = net.createServer(common.mustNotCall()); | ||
|
||
server.listen(common.mustCall(function() { | ||
assert.ok(server.address().port > 100); | ||
server.close(); | ||
})); | ||
} | ||
|
||
// No callback to listen(), assume we can bind in 100 ms | ||
{ | ||
const server = net.createServer(common.mustNotCall()); | ||
|
||
server.listen(common.PORT); | ||
|
||
setTimeout(function() { | ||
const address = server.address(); | ||
assert.strictEqual(address.port, common.PORT); | ||
|
||
if (address.family === 'IPv6') | ||
assert.strictEqual(server._connectionKey, `6::::${address.port}`); | ||
else | ||
assert.strictEqual(server._connectionKey, `4:0.0.0.0:${address.port}`); | ||
|
||
server.close(); | ||
}, 100); | ||
} | ||
|
||
// Callback to listen() | ||
{ | ||
const server = net.createServer(common.mustNotCall()); | ||
|
||
server.listen(common.PORT + 1, common.mustCall(function() { | ||
assert.strictEqual(server.address().port, common.PORT + 1); | ||
server.close(); | ||
})); | ||
} | ||
|
||
// Backlog argument | ||
{ | ||
const server = net.createServer(common.mustNotCall()); | ||
|
||
server.listen(common.PORT + 2, '0.0.0.0', 127, common.mustCall(function() { | ||
assert.strictEqual(server.address().port, common.PORT + 2); | ||
server.close(); | ||
})); | ||
} | ||
|
||
// Backlog argument without host argument | ||
{ | ||
const server = net.createServer(common.mustNotCall()); | ||
|
||
server.listen(common.PORT + 3, 127, common.mustCall(function() { | ||
assert.strictEqual(server.address().port, common.PORT + 3); | ||
server.close(); | ||
})); | ||
} |