fs: Change default mode to COPYFILE_FICLONE

Author: HinataKah0

doc/api/fs.md

@@ -924,7 +924,7 @@ changes:
   operation. It is possible to create a mask consisting of the bitwise OR of
   two or more values (e.g.
   `fs.constants.COPYFILE_EXCL | fs.constants.COPYFILE_FICLONE`)
-  **Default:** `0`.
+  **Default:** `fs.constants.COPYFILE_FICLONE`.
   * `fs.constants.COPYFILE_EXCL`: The copy operation will fail if `dest`
     already exists.
   * `fs.constants.COPYFILE_FICLONE`: The copy operation will attempt to create
@@ -5187,7 +5187,7 @@ changes:
 
 * `src` {string|Buffer|URL} source filename to copy
 * `dest` {string|Buffer|URL} destination filename of the copy operation
-* `mode` {integer} modifiers for copy operation. **Default:** `0`.
+* `mode` {integer} modifiers for copy operation. **Default:** `fs.constants.COPYFILE_FICLONE`.
 
 Synchronously copies `src` to `dest`. By default, `dest` is overwritten if it
 already exists. Returns `undefined`. Node.js makes no guarantees about the

lib/fs.js

@@ -92,6 +92,7 @@ const {
 } = require('internal/util');
 const {
   constants: {
+    kDefaultCopyMode,
     kIoMaxLength,
     kMaxUserId,
   },
@@ -2942,7 +2943,7 @@ function mkdtempSync(prefix, options) {
 function copyFile(src, dest, mode, callback) {
   if (typeof mode === 'function') {
     callback = mode;
-    mode = 0;
+    mode = kDefaultCopyMode;
   }
 
   src = getValidatedPath(src, 'src');

lib/internal/fs/utils.js

@@ -112,16 +112,11 @@ const {
 const kMinimumAccessMode = MathMin(F_OK, W_OK, R_OK, X_OK);
 const kMaximumAccessMode = F_OK | W_OK | R_OK | X_OK;
 
-const kDefaultCopyMode = 0;
+const kDefaultCopyMode = COPYFILE_FICLONE;
 // The copy modes can be any of COPYFILE_EXCL, COPYFILE_FICLONE or
 // COPYFILE_FICLONE_FORCE. They can be used in combination as well
 // (COPYFILE_EXCL | COPYFILE_FICLONE | COPYFILE_FICLONE_FORCE).
-const kMinimumCopyMode = MathMin(
-  kDefaultCopyMode,
-  COPYFILE_EXCL,
-  COPYFILE_FICLONE,
-  COPYFILE_FICLONE_FORCE,
-);
+const kMinimumCopyMode = 0;
 const kMaximumCopyMode = COPYFILE_EXCL |
                          COPYFILE_FICLONE |
                          COPYFILE_FICLONE_FORCE;
@@ -927,6 +922,7 @@ const validatePosition = hideStackFrames((position, name) => {
 
 module.exports = {
   constants: {
+    kDefaultCopyMode,
     kIoMaxLength,
     kMaxUserId,
     kReadFileBufferLength,

test/parallel/test-fs-copyfile.js

@@ -6,6 +6,7 @@ const tmpdir = require('../common/tmpdir');
 const assert = require('assert');
 const fs = require('fs');
 const { internalBinding } = require('internal/test/binding');
+const { getValidMode } = require('internal/fs/utils');
 const {
   UV_ENOENT,
   UV_EEXIST
@@ -61,6 +62,9 @@ fs.unlinkSync(dest);
 fs.copyFileSync(src, dest, UV_FS_COPYFILE_FICLONE);
 verify(src, dest);
 
+// Verify that default mode is COPYFILE_FICLONE.
+assert.strictEqual(getValidMode(null, 'copyFile'), COPYFILE_FICLONE);
+
 // Verify that COPYFILE_FICLONE_FORCE can be used.
 try {
   fs.unlinkSync(dest);