Skip to content

Commit

Permalink
doc: revise accepting-modifications in guide
Browse files Browse the repository at this point in the history
Revise the "Accepting Modifications" section of the Collaborator Guide.

PR-URL: #24650
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
  • Loading branch information
Trott authored and targos committed Nov 28, 2018
1 parent 99dbdca commit 85aa030
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions COLLABORATOR_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,10 @@ to land but is [author ready](#author-ready-pull-requests), add the

## Accepting Modifications

All modifications to the Node.js code and documentation should be performed via
GitHub pull requests, including modifications by Collaborators and TSC members.
A pull request must be reviewed, and must also be tested with CI, before being
landed into the codebase. There may be exceptions to the latter (the changed
code cannot be tested with a CI or similar). If that is the case, please leave a
comment that explains why the PR does not require a CI run.
Contributors propose modifications to Node.js using GitHub pull requests. This
is true for all modifications including those proposed by TSC members and other
Collaborators. A pull request must pass code review and CI before landing into
the codebase.

### Code Reviews

Expand Down

0 comments on commit 85aa030

Please sign in to comment.