Skip to content

Commit

Permalink
test: fix test_worker_terminate_finalization
Browse files Browse the repository at this point in the history
The test was missing an initialization of the global `ref` variable
because there was also an unused local one, leading to failures
like the one seen in #34625.

PR-URL: #34726
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
  • Loading branch information
addaleax authored and BethGriggs committed Aug 20, 2020
1 parent 230bcaf commit 8e91f3e
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ napi_value Test(napi_env env, napi_callback_info info) {
size_t argc = 1;
napi_value argv[1];
napi_value result;
napi_ref ref;
void* bufferData = malloc(BUFFER_SIZE);

NAPI_CALL(env, napi_get_cb_info(env, info, &argc, argv, NULL, NULL));
Expand Down

0 comments on commit 8e91f3e

Please sign in to comment.