Skip to content

Commit 91b8da6

Browse files
thefourtheyeMylesBorins
authored andcommitted
test: skip the test with proper TAP message
On Windows, the test simply returns which will be counted as passed. The test actually skips the rest of the test. So proper TAP message has to be included while skipping. This patch uses `common.skip` rather than `console.log` to print the skip messages. PR-URL: #11584 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent e8f0dba commit 91b8da6

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

test/parallel/test-setproctitle.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ const common = require('../common');
44

55
// FIXME add sunos support
66
if (!(common.isFreeBSD || common.isOSX || common.isLinux)) {
7-
console.log(`1..0 # Skipped: Unsupported platform [${process.platform}]`);
8-
return;
7+
return common.skip(`Unsupported platform [${process.platform}]`);
98
}
109

1110
const assert = require('assert');

0 commit comments

Comments
 (0)