Skip to content

Commit

Permalink
deps: silence V8's warning on CompileFunction
Browse files Browse the repository at this point in the history
We are not ready to migrate yet.

Refs: nodejs/node-v8#214

PR-URL: #40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
targos committed Jan 20, 2022
1 parent 1ad4409 commit 9318408
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion deps/v8/include/v8-script.h
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,6 @@ class V8_EXPORT ScriptCompiler {
* It is possible to specify multiple context extensions (obj in the above
* example).
*/
V8_DEPRECATE_SOON("Use CompileFunction")
static V8_WARN_UNUSED_RESULT MaybeLocal<Function> CompileFunctionInContext(
Local<Context> context, Source* source, size_t arguments_count,
Local<String> arguments[], size_t context_extension_count,
Expand Down

0 comments on commit 9318408

Please sign in to comment.