Skip to content

Commit 9396a9f

Browse files
committed
deps: cherry-pick 8bfbe25 from upstream V8
Original commit message: [compiler] Fix typing of NumberToString operator. It must be monotone. R=bmeurer@chromium.org Bug: v8:7354 Change-Id: I08dcd3333518029eef08c074c2b91b5c20ad699e Reviewed-on: https://chromium-review.googlesource.com/880982 Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#50801} Refs: v8/v8@8bfbe25 PR-URL: #18453 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yang Guo <yangguo@chromium.org> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
1 parent d68ee7e commit 9396a9f

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
# Reset this number to 0 on major V8 upgrades.
2929
# Increment by one for each non-official patch applied to deps/v8.
30-
'v8_embedder_string': '-node.1',
30+
'v8_embedder_string': '-node.2',
3131

3232
# Enable disassembler for `--print-code` v8 options
3333
'v8_enable_disassembler': 1,

deps/v8/src/compiler/operation-typer.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -507,7 +507,7 @@ Type* OperationTyper::NumberToInt32(Type* type) {
507507

508508
Type* OperationTyper::NumberToString(Type* type) {
509509
DCHECK(type->Is(Type::Number()));
510-
510+
if (type->IsNone()) return type;
511511
if (type->Is(Type::NaN())) return singleton_NaN_string_;
512512
if (type->Is(cache_.kZeroOrMinusZero)) return singleton_zero_string_;
513513
return Type::SeqString();

0 commit comments

Comments
 (0)