Skip to content

Commit

Permalink
test: refactor test-debug-prompt
Browse files Browse the repository at this point in the history
* Use cleaner `process.stdin.write('.exit')` to exit the process rather
  than `proc.kill()`.
* Move test to sequential. It uses the default port 9229. It will fail
  if another inspector test (or test using port 0) is already using that
  port. So it needs to be run sequentially rather than in parallel with
  other tests. (We haven't seen many failures with it yet because there
  aren't a lot of other inspector tests in parallel at this time.)

PR-URL: #15141
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
Trott authored and jasnell committed Sep 20, 2017
1 parent 5881033 commit 94e2b5c
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ let output = '';
proc.stdout.on('data', (data) => {
output += data;
if (output.includes('debug> '))
proc.kill();
proc.stdin.write('.exit\n');
});

0 comments on commit 94e2b5c

Please sign in to comment.