Skip to content

Commit 9c460d7

Browse files
committed
deps: add back no-op harmony shipping flags
Add back the no-op harmony shipping flags that were removed in V8 5.1 to increase compatibility with V8 5.0 that we had been shipping before v6.5.0. These flags do nothing. Fixes: #8388 Ref: #8395 PR-URL: #8445 Reviewed-By: addaleax - Anna Henningsen <anna@addaleax.net> Reviewed-By: thealphanerd - Myles Borins <myles.borins@gmail.com> Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
1 parent dd51b1f commit 9c460d7

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

deps/v8/include/v8-version.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#define V8_MAJOR_VERSION 5
1212
#define V8_MINOR_VERSION 1
1313
#define V8_BUILD_NUMBER 281
14-
#define V8_PATCH_LEVEL 82
14+
#define V8_PATCH_LEVEL 83
1515

1616
// Use 1 for candidates and 0 otherwise.
1717
// (Boolean macro values are not supported by all preprocessors.)

deps/v8/src/flag-definitions.h

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,20 @@ DEFINE_IMPLICATION(es_staging, move_object_start)
235235
// and associated tests are moved from the harmony directory to the appropriate
236236
// esN directory.
237237

238+
// no-op flags added back for V8 5.0 compatibility for Node.js v6.x.
239+
#define NODE_NOP_HARMONY_FEATURES(V) \
240+
V(harmony_default_parameters, "harmony default parameters") \
241+
V(harmony_destructuring_assignment, "harmony destructuring assignment") \
242+
V(harmony_destructuring_bind, "harmony destructuring bind") \
243+
V(harmony_regexps, "harmony regular expression extensions") \
244+
V(harmony_proxies, "harmony proxies") \
245+
V(harmony_reflect, "harmony Reflect API") \
246+
V(harmony_tostring, "harmony toString")
247+
248+
#define FLAG_NODE_NOP_HARMONY_FEATURES(id, description) \
249+
DEFINE_BOOL(id, true, "nop flag for " #description)
250+
NODE_NOP_HARMONY_FEATURES(FLAG_NODE_NOP_HARMONY_FEATURES)
251+
#undef FLAG_NODE_NOP_HARMONY_FEATURES
238252

239253
#define FLAG_INPROGRESS_FEATURES(id, description) \
240254
DEFINE_BOOL(id, false, "enable " #description " (in progress)")

0 commit comments

Comments
 (0)