buffer: alias toLocaleString to toString

Make Buffer.prototype.toLocaleString an alias of Buffer.prototype.toString so that the output is actually useful. Fixes: #8147 PR-URL: #8148 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
nodejs · Aug 23, 2016 · 9cee8b1 · 9cee8b1
1 parent 0764bc4
commit 9cee8b1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -1332,3 +1332,5 @@ Buffer.prototype.swap64 = function swap64() {
   }
   return swap64n(this);
 };
+
+Buffer.prototype.toLocaleString = Buffer.prototype.toString;
diff --git a/test/parallel/test-buffer-alloc.js b/test/parallel/test-buffer-alloc.js
@@ -1502,3 +1502,9 @@ assert.throws(() => Buffer.alloc({ valueOf: () => 1 }),
               /"size" argument must be a number/);
 assert.throws(() => Buffer.alloc({ valueOf: () => -1 }),
               /"size" argument must be a number/);
+
+assert.strictEqual(Buffer.prototype.toLocaleString, Buffer.prototype.toString);
+{
+  const buf = Buffer.from('test');
+  assert.strictEqual(buf.toLocaleString(), buf.toString());
+}