Skip to content

Commit 9e6b0a4

Browse files
refackitaloacasas
authored andcommitted
test: performance, remove Popen(shell=True) on Win
not needed according to official python docs - https://docs.python.org/2/library/subprocess.html#index-2 PR-URL: #12138 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 805ebef commit 9e6b0a4

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

Diff for: tools/test.py

-1
Original file line numberDiff line numberDiff line change
@@ -616,7 +616,6 @@ def RunProcess(context, timeout, args, **rest):
616616
pty_out = rest.pop('pty_out')
617617

618618
process = subprocess.Popen(
619-
shell = utils.IsWindows(),
620619
args = popen_args,
621620
**rest
622621
)

0 commit comments

Comments
 (0)