Skip to content

Commit

Permalink
build: restore libplatform headers in distribution
Browse files Browse the repository at this point in the history
Headers considered non-essential were removed in #37570, however the
libplatform API is actualy needed (and used) by external software
initiaing the v8 engine, see for example:
https://chromium.googlesource.com/v8/v8/+/refs/heads/main/samples/hello-world.cc

PR-URL: #39288
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
jeroen authored and targos committed Jul 11, 2021
1 parent 2481ddd commit a7ba218
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tools/install.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,9 @@ def headers(action):
def wanted_v8_headers(files_arg, dest):
v8_headers = [
'deps/v8/include/cppgc/common.h',
'deps/v8/include/libplatform/libplatform.h',
'deps/v8/include/libplatform/libplatform-export.h',
'deps/v8/include/libplatform/v8-tracing.h',
'deps/v8/include/v8.h',
'deps/v8/include/v8-internal.h',
'deps/v8/include/v8-platform.h',
Expand Down

0 comments on commit a7ba218

Please sign in to comment.