Skip to content

Commit

Permalink
test: explicitly set global in test-repl
Browse files Browse the repository at this point in the history
The test intentionally assigns a global. Use `global` namespace to make
it clear that it is intentional and not an accidental leak.

PR-URL: #6026
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
Trott authored and Myles Borins committed Apr 11, 2016
1 parent 0870ac6 commit ac40a45
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/parallel/test-repl.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ var moduleFilename = require('path').join(common.fixturesDir, 'a');
console.error('repl test');

// function for REPL to run
invoke_me = function(arg) {
global.invoke_me = function(arg) {
return 'invoked ' + arg;
};

Expand Down

0 comments on commit ac40a45

Please sign in to comment.