Skip to content

Commit

Permalink
build: exit on unsupported host OS for Android
Browse files Browse the repository at this point in the history
The Android configure script throws an unhelpful error message telling
the user that `toolchain_path` is not defined when the script is run on
an unsupported host OS, exit with a more helpful message instead while
listing the supported host OSes.

PR-URL: #52882
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
VoltrexKeyva authored and marco-ippolito committed Jul 19, 2024
1 parent 2a1fde7 commit acdbc78
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions android_configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ def patch_android():
os.system('patch -f ./deps/v8/src/trap-handler/trap-handler.h < ./android-patches/trap-handler.h.patch')
print("\033[92mInfo: \033[0m" + "Tried to patch.")

if platform.system() == "Windows":
print("android-configure is not supported on Windows yet.")
if platform.system() != "Linux" and platform.system() != "Darwin":
print("android-configure is currently only supported on Linux and Darwin.")
sys.exit(1)

if len(sys.argv) == 2 and sys.argv[1] == "patch":
Expand Down

0 comments on commit acdbc78

Please sign in to comment.