lib: add %TypedArray% abstract constructor to primordials

Refs: #35448 Refs: #36003 Refs: https://tc39.es/ecma262/#sec-%typedarray%-intrinsic-object Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #36016 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
nodejs · Nov 9, 2020 · af2a560 · af2a560
1 parent 77e4f19
commit af2a560
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 9 deletions.
diff --git a/lib/internal/freeze_intrinsics.js b/lib/internal/freeze_intrinsics.js
@@ -65,6 +65,8 @@ const {
   SymbolIterator,
   SyntaxError,
   TypeError,
+  TypedArray,
+  TypedArrayPrototype,
   Uint16Array,
   Uint32Array,
   Uint8Array,
@@ -105,7 +107,7 @@ module.exports = function() {
     // AsyncGeneratorFunction
     ObjectGetPrototypeOf(async function* () {}),
     // TypedArray
-    ObjectGetPrototypeOf(Uint8Array),
+    TypedArrayPrototype,
 
     // 19 Fundamental Objects
     Object.prototype, // 19.1
@@ -189,7 +191,7 @@ module.exports = function() {
     // AsyncGeneratorFunction
     ObjectGetPrototypeOf(async function* () {}),
     // TypedArray
-    ObjectGetPrototypeOf(Uint8Array),
+    TypedArray,
 
     // 18 The Global Object
     eval,

diff --git a/lib/internal/per_context/primordials.js b/lib/internal/per_context/primordials.js
@@ -175,5 +175,18 @@ primordials.SafePromise = makeSafe(
   copyPrototype(original.prototype, primordials, `${name}Prototype`);
 });
 
+// Create copies of abstract intrinsic objects that are not directly exposed
+// on the global object.
+// Refs: https://tc39.es/ecma262/#sec-%typedarray%-intrinsic-object
+[
+  { name: 'TypedArray', original: Reflect.getPrototypeOf(Uint8Array) },
+].forEach(({ name, original }) => {
+  primordials[name] = original;
+  // The static %TypedArray% methods require a valid `this`, but can't be bound,
+  // as they need a subclass constructor as the receiver:
+  copyPrototype(original, primordials, name);
+  copyPrototype(original.prototype, primordials, `${name}Prototype`);
+});
+
 Object.setPrototypeOf(primordials, null);
 Object.freeze(primordials);
diff --git a/lib/internal/util/inspect.js b/lib/internal/util/inspect.js
@@ -57,10 +57,10 @@ const {
   SymbolPrototypeValueOf,
   SymbolIterator,
   SymbolToStringTag,
+  TypedArrayPrototype,
   Uint16Array,
   Uint32Array,
   Uint8Array,
-  Uint8ArrayPrototype,
   Uint8ClampedArray,
   uncurryThis,
 } = primordials;
@@ -141,8 +141,7 @@ const setSizeGetter = uncurryThis(
 const mapSizeGetter = uncurryThis(
   ObjectGetOwnPropertyDescriptor(MapPrototype, 'size').get);
 const typedArraySizeGetter = uncurryThis(
-  ObjectGetOwnPropertyDescriptor(
-    ObjectGetPrototypeOf(Uint8ArrayPrototype), 'length').get);
+  ObjectGetOwnPropertyDescriptor(TypedArrayPrototype, 'length').get);
 
 let hexSlice;
 

diff --git a/lib/internal/util/types.js b/lib/internal/util/types.js
@@ -3,14 +3,11 @@
 const {
   ArrayBufferIsView,
   ObjectGetOwnPropertyDescriptor,
-  ObjectGetPrototypeOf,
   SymbolToStringTag,
-  Uint8ArrayPrototype,
+  TypedArrayPrototype,
   uncurryThis,
 } = primordials;
 
-const TypedArrayPrototype = ObjectGetPrototypeOf(Uint8ArrayPrototype);
-
 const TypedArrayProto_toStringTag =
     uncurryThis(
       ObjectGetOwnPropertyDescriptor(TypedArrayPrototype,