stream: cleanup use of internal ended state

PR-URL: #29645 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs · Sep 25, 2019 · b100897 · b100897
1 parent b7488c2
commit b100897
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/lib/internal/http2/compat.js b/lib/internal/http2/compat.js
@@ -303,7 +303,7 @@ class Http2ServerRequest extends Readable {
 
   get complete() {
     return this[kAborted] ||
-           this._readableState.ended ||
+           this.readableEnded ||
            this[kState].closed ||
            this[kStream].destroyed;
   }

diff --git a/lib/internal/worker.js b/lib/internal/worker.js
@@ -207,11 +207,11 @@ class Worker extends EventEmitter {
 
     const { stdout, stderr } = this[kParentSideStdio];
 
-    if (!stdout._readableState.ended) {
+    if (!stdout.readableEnded) {
       debug(`[${threadId}] explicitly closes stdout for ${this.threadId}`);
       stdout.push(null);
     }
-    if (!stderr._readableState.ended) {
+    if (!stderr.readableEnded) {
       debug(`[${threadId}] explicitly closes stderr for ${this.threadId}`);
       stderr.push(null);
     }

diff --git a/lib/net.js b/lib/net.js
@@ -422,7 +422,7 @@ function afterShutdown(status) {
   if (self.destroyed)
     return;
 
-  if (!self.readable || self._readableState.ended) {
+  if (!self.readable || self.readableEnded) {
     debug('readableState ended, destroying');
     self.destroy();
   }