Skip to content

Commit b353549

Browse files
joyeecheungtargos
authored andcommitted
doc: mention adding Fixes to collaborator onboarding PR
Also update the example to include the Fixes url. PR-URL: #37097 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
1 parent 55a7b0c commit b353549

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

onboarding.md

+6-3
Original file line numberDiff line numberDiff line change
@@ -204,11 +204,14 @@ needs to be pointed out separately during the onboarding.
204204
## Exercise: Make a PR adding yourself to the README
205205

206206
* Example:
207-
<https://github.com/nodejs/node/commit/ce986de829457c39257cd205067602e765768fb0>
208-
* For raw commit message: `git log ce986de829457c39257cd205067602e765768fb0
209-
-1`
207+
<https://github.com/nodejs/node/commit/b58fe52692659c0bc25ddbe6afa7f4ae2c7f14a8>
208+
* For raw commit message:
209+
`git show --format=%Bb58fe52692659c0bc25ddbe6afa7f4ae2c7f14a8`
210210
* Collaborators are in alphabetical order by GitHub username.
211211
* Optionally, include your personal pronouns.
212+
* Add the `Fixes: <collaborator-nomination-issue-url>` to the commit message
213+
so that when the commit lands, the nomination issue url will be
214+
automatically closed.
212215
* Label your pull request with the `doc`, `notable-change`, and `fast-track`
213216
labels.
214217
* Run CI on the PR. Use the `node-test-pull-request` CI task.

0 commit comments

Comments
 (0)