-
Notifications
You must be signed in to change notification settings - Fork 30k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
benchmark: URLSearchParams v.s. querystring
Add benchmarks to compare the performance between URLSearchParams and querystring, remove duplicate benchmarks. PR-URL: #11170 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
- Loading branch information
1 parent
6d2797b
commit b4f3a30
Showing
4 changed files
with
126 additions
and
66 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
'use strict'; | ||
const common = require('../common.js'); | ||
const { URLSearchParams } = require('url'); | ||
const querystring = require('querystring'); | ||
|
||
const inputs = { | ||
noencode: 'foo=bar&baz=quux&xyzzy=thud', | ||
encodemany: '%66%6F%6F=bar&%62%61%7A=quux&xyzzy=%74h%75d', | ||
encodefake: 'foo=%©ar&baz=%A©uux&xyzzy=%©ud', | ||
encodelast: 'foo=bar&baz=quux&xyzzy=thu%64', | ||
multicharsep: 'foo=bar&&&&&&&&&&baz=quux&&&&&&&&&&xyzzy=thud', | ||
multivalue: 'foo=bar&foo=baz&foo=quux&quuy=quuz', | ||
multivaluemany: 'foo=bar&foo=baz&foo=quux&quuy=quuz&foo=abc&foo=def&' + | ||
'foo=ghi&foo=jkl&foo=mno&foo=pqr&foo=stu&foo=vwxyz', | ||
manypairs: 'a&b&c&d&e&f&g&h&i&j&k&l&m&n&o&p&q&r&s&t&u&v&w&x&y&z' | ||
}; | ||
|
||
const bench = common.createBenchmark(main, { | ||
type: Object.keys(inputs), | ||
method: ['legacy', 'whatwg'], | ||
n: [1e5] | ||
}); | ||
|
||
function useLegacy(n, input) { | ||
querystring.parse(input); | ||
bench.start(); | ||
for (var i = 0; i < n; i += 1) { | ||
querystring.parse(input); | ||
} | ||
bench.end(n); | ||
} | ||
|
||
function useWHATWG(n, input) { | ||
new URLSearchParams(input); | ||
bench.start(); | ||
for (var i = 0; i < n; i += 1) { | ||
new URLSearchParams(input); | ||
} | ||
bench.end(n); | ||
} | ||
|
||
function main(conf) { | ||
const type = conf.type; | ||
const n = conf.n | 0; | ||
const method = conf.method; | ||
|
||
const input = inputs[type]; | ||
if (!input) { | ||
throw new Error('Unknown input type'); | ||
} | ||
|
||
switch (method) { | ||
case 'legacy': | ||
useLegacy(n, input); | ||
break; | ||
case 'whatwg': | ||
useWHATWG(n, input); | ||
break; | ||
default: | ||
throw new Error('Unknown method'); | ||
} | ||
} |
64 changes: 64 additions & 0 deletions
64
benchmark/url/legacy-vs-whatwg-url-searchparams-serialize.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
'use strict'; | ||
const common = require('../common.js'); | ||
const { URLSearchParams } = require('url'); | ||
const querystring = require('querystring'); | ||
|
||
const inputs = { | ||
noencode: 'foo=bar&baz=quux&xyzzy=thud', | ||
encodemany: '%66%6F%6F=bar&%62%61%7A=quux&xyzzy=%74h%75d', | ||
encodefake: 'foo=%©ar&baz=%A©uux&xyzzy=%©ud', | ||
encodelast: 'foo=bar&baz=quux&xyzzy=thu%64', | ||
multicharsep: 'foo=bar&&&&&&&&&&baz=quux&&&&&&&&&&xyzzy=thud', | ||
multivalue: 'foo=bar&foo=baz&foo=quux&quuy=quuz', | ||
multivaluemany: 'foo=bar&foo=baz&foo=quux&quuy=quuz&foo=abc&foo=def&' + | ||
'foo=ghi&foo=jkl&foo=mno&foo=pqr&foo=stu&foo=vwxyz', | ||
manypairs: 'a&b&c&d&e&f&g&h&i&j&k&l&m&n&o&p&q&r&s&t&u&v&w&x&y&z' | ||
}; | ||
|
||
const bench = common.createBenchmark(main, { | ||
type: Object.keys(inputs), | ||
method: ['legacy', 'whatwg'], | ||
n: [1e5] | ||
}); | ||
|
||
function useLegacy(n, input, prop) { | ||
const obj = querystring.parse(input); | ||
querystring.stringify(obj); | ||
bench.start(); | ||
for (var i = 0; i < n; i += 1) { | ||
querystring.stringify(obj); | ||
} | ||
bench.end(n); | ||
} | ||
|
||
function useWHATWG(n, input, prop) { | ||
const obj = new URLSearchParams(input); | ||
obj.toString(); | ||
bench.start(); | ||
for (var i = 0; i < n; i += 1) { | ||
obj.toString(); | ||
} | ||
bench.end(n); | ||
} | ||
|
||
function main(conf) { | ||
const type = conf.type; | ||
const n = conf.n | 0; | ||
const method = conf.method; | ||
|
||
const input = inputs[type]; | ||
if (!input) { | ||
throw new Error('Unknown input type'); | ||
} | ||
|
||
switch (method) { | ||
case 'legacy': | ||
useLegacy(n, input); | ||
break; | ||
case 'whatwg': | ||
useWHATWG(n, input); | ||
break; | ||
default: | ||
throw new Error('Unknown method'); | ||
} | ||
} |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.