src: avoid heap allocation in crypto.pbkdf2()

PR-URL: #14122 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Jul 18, 2017 · b5802c7 · b5802c7
1 parent 1c3e090
commit b5802c7
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -5355,8 +5355,9 @@ void PBKDF2Request::Work(uv_work_t* work_req) {
 void PBKDF2Request::After(Local<Value> (*argv)[2]) {
   if (error()) {
     (*argv)[0] = Undefined(env()->isolate());
-    (*argv)[1] = Encode(env()->isolate(), key(), keylen(), BUFFER);
-    OPENSSL_cleanse(key(), keylen());
+    (*argv)[1] = Buffer::New(env(), key(), keylen()).ToLocalChecked();
+    key_ = nullptr;
+    keylen_ = 0;
   } else {
     (*argv)[0] = Exception::Error(env()->pbkdf2_error_string());
     (*argv)[1] = Undefined(env()->isolate());