Skip to content

Commit

Permalink
benchmark: add a benchmark for URLSearchParams creation and toString()
Browse files Browse the repository at this point in the history
Refs: nodejs/performance#56
PR-URL: #46810
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
  • Loading branch information
debadree25 authored and danielleadams committed Apr 11, 2023
1 parent bce37c6 commit b5db3b5
Show file tree
Hide file tree
Showing 2 changed files with 155 additions and 0 deletions.
79 changes: 79 additions & 0 deletions benchmark/url/url-searchparams-creation.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
'use strict';
const common = require('../common.js');

const values = {
noencode: {
foo: 'bar',
baz: 'quux',
xyzzy: 'thud',
},
encodemany: {
'\u0080\u0083\u0089': 'bar',
'\u008C\u008E\u0099': 'quux',
'xyzzy': '\u00A5q\u00A3r',
},
encodelast: {
foo: 'bar',
baz: 'quux',
xyzzy: 'thu\u00AC',
},
array: {
foo: [],
baz: ['bar'],
xyzzy: ['bar', 'quux', 'thud'],
},
multiprimitives: {
foo: false,
bar: -13.37,
baz: 'baz',
},
};

function paramGenerator(paramType) {
const valueKeys = Object.keys(values);
switch (paramType) {
case 'string':
// Return the values object with all values as strings
return valueKeys.reduce((acc, key) => {
acc[key] = Object.keys(values[key]).reduce((acc, k, i) => {
acc += `${k}=${values[key][k]}${i < valueKeys.length - 1 ? '&' : ''}`;
return acc;
}, '');
return acc;
}, {});
case 'iterable':
// Return the values object with all values as iterable
return valueKeys.reduce((acc, key) => {
acc[key] = Object.keys(values[key]).reduce((acc, k) => {
acc.push([k, values[key][k]]);
return acc;
}, []);
return acc;
}, {});
case 'object':
// Return the values object with all values as objects
return values;
default:
}
}

const bench = common.createBenchmark(main, {
type: ['noencode', 'encodemany', 'encodelast', 'array', 'multiprimitives'],
inputType: ['string', 'iterable', 'object'],
n: [1e6],
});

function main({ n, type, inputType }) {
const inputs = paramGenerator(inputType);
const input = inputs[type];

// Force optimization before starting the benchmark
for (const name in inputs) {
new URLSearchParams(inputs[name]);
}

bench.start();
for (let i = 0; i < n; i += 1)
new URLSearchParams(input);
bench.end(n);
}
76 changes: 76 additions & 0 deletions benchmark/url/url-searchparams-toString.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
'use strict';
const common = require('../common.js');

const values = {
noencode: {
foo: 'bar',
baz: 'quux',
xyzzy: 'thud',
},
encodemany: {
'\u0080\u0083\u0089': 'bar',
'\u008C\u008E\u0099': 'quux',
'xyzzy': '\u00A5q\u00A3r',
},
encodelast: {
foo: 'bar',
baz: 'quux',
xyzzy: 'thu\u00AC',
},
array: {
foo: [],
baz: ['bar'],
xyzzy: ['bar', 'quux', 'thud'],
},
multiprimitives: {
foo: false,
bar: -13.37,
baz: 'baz',
},
};

function paramGenerator(paramType) {
const valueKeys = Object.keys(values);
switch (paramType) {
case 'string':
// Return the values object with all values as strings
return valueKeys.reduce((acc, key) => {
const objectKeys = Object.keys(values[key]);
acc[key] = objectKeys.reduce((acc, k, i) => {
acc += `${k}=${values[key][k]}${i < objectKeys.length - 1 ? '&' : ''}`;
return acc;
}, '');
return acc;
}, {});
case 'iterable':
// Return the values object with all values as iterable
return valueKeys.reduce((acc, key) => {
acc[key] = Object.keys(values[key]).reduce((acc, k) => {
acc.push([k, values[key][k]]);
return acc;
}, []);
return acc;
}, {});
case 'object':
// Return the values object with all values as objects
return values;
default:
}
}

const bench = common.createBenchmark(main, {
type: ['noencode', 'encodemany', 'encodelast', 'array', 'multiprimitives'],
inputType: ['string', 'iterable', 'object'],
n: [1e6],
});

function main({ n, type, inputType }) {
const inputs = paramGenerator(inputType);
const input = inputs[type];
const u = new URLSearchParams(input);

bench.start();
for (let i = 0; i < n; i += 1)
u.toString();
bench.end(n);
}

0 comments on commit b5db3b5

Please sign in to comment.